Eradicate OStringStream and OFStream #22

Closed
jwpeterson opened this Issue Dec 20, 2012 · 5 comments

3 participants

@jwpeterson
libMesh - C++ Finite Element Library member

We kind of look like chumps for still having this stuff in the code... they were put in to support compilers with broken std versions of the same, but I don't know of any current compilers that still fit that description. They are full of non-standard macros. Standard-conforming code will be longer but much more expressive.

@jwpeterson jwpeterson added a commit that referenced this issue Dec 20, 2012
@jwpeterson jwpeterson Removing OStringStream from PerfLog.
Issue #22.
0f0a6a2
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Removing OStringStream from various classes.
DofMap
AdjointResidualErrorEstimator
Utility
UniformRefinementEstimator
EnsightIO
UnstructuredMesh
DerivedRBEvaluation
RBEIMConstruction
RBEIMEvaluation
RBEvaluation
RBSCMEvaluation
TransientRBConstruction
TransientRBEvaluation
System
Xdr

Issue #22.
756f29c
@benkirk
libMesh - C++ Finite Element Library member

Agreed. I raised a similar question about AutoPtr<> a while back, IIRC our implementation is precisely the std::auto_ptr<> source from an ancient, circa 2002 gcc.

You are going to leave the header in place for a little while though, right? Perhaps with a libmesh_deprecated() in the header?

@jwpeterson
libMesh - C++ Finite Element Library member
@benkirk
libMesh - C++ Finite Element Library member
@roystgnr
libMesh - C++ Finite Element Library member
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Removing OStringStream from PetscVector.
Issue #22.
eae4ed5
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Removing OStringStream from various examples:
adaptivity_ex2
adaptivity_ex3
adjoints_ex1
adjoints_ex2
adjoints_ex3
adjoints_ex4
fem_system_ex1
miscellaneous_ex4
reduced_basis_ex2
reduced_basis_ex3
systems_of_equations_ex2
systems_of_equations_ex3
transient_ex1

Issue #22.
4b40fb3
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Deprecating OStringStream.
Issue #22.
de36dd3
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Removing OFStream from XdrMGF.
Issue #22.
fcc6c45
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Removing OFStream from Xdr.
Issue #22.
9f7dde0
@jwpeterson jwpeterson added a commit that referenced this issue Dec 21, 2012
@jwpeterson jwpeterson Deprecating OFStream.
Issue #22.
05a90de
@jwpeterson
libMesh - C++ Finite Element Library member

Agreed. I raised a similar question about AutoPtr<> a while back, IIRC our implementation is precisely the
std::auto_ptr<> source from an ancient, circa 2002 gcc.

std::auto_ptr has actually been deprecated in C++11

http://en.wikipedia.org/wiki/Auto_ptr

So for that one I'd say let's just wait a few more years and replace AutoPtr with std::unique_ptr instead...

@jwpeterson jwpeterson closed this Dec 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment