Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Make code compile warning free with -Wshadow #24

Closed
jwpeterson opened this Issue · 6 comments

2 participants

@jwpeterson
Owner

Note that -Wall does not turn on -Wshadow.

@jwpeterson
Owner

The code (including the examples) now compiles warning free for me with -Wshadow.

Has anyone (@roystgnr, @pbauman) added a buildbot target with -Wshadow on the Pecos side yet? If yes, is there a way I could get access to the output? If not, I'll bug our Trac guy to add one over here...

@roystgnr
Owner
@jwpeterson
Owner

@roystgnr is that -Wshadow buildbot configuration set up yet by any chance?

@roystgnr
Owner
@jwpeterson
Owner

Great! Remind me again where I can find the buildbot page on ICES...?

@roystgnr roystgnr referenced this issue from a commit
@roystgnr roystgnr Fixes for -Wshadow warnings
We're also going to have to do some ignore_warnings/restore_warnings
trickery before -Wshadow is useful again; my PETSc build has a few
cases of shadowing and Eigen is full of them.

Issue #24
5912928
@roystgnr roystgnr referenced this issue from a commit
@roystgnr roystgnr Fixes for -Wshadow warnings
We're also going to have to do some ignore_warnings/restore_warnings
trickery before -Wshadow is useful again; my PETSc build has a few
cases of shadowing and Eigen is full of them.

Issue #24
cb03cef
@jwpeterson
Owner

Closing this standing issue, it can always be referenced from new commits at any time.

@jwpeterson jwpeterson closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.