Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

MeshCommunication::gather() #193

Merged
merged 2 commits into from Jan 28, 2014

Conversation

Projects
None yet
2 participants
Owner

benkirk commented Jan 28, 2014

Hey @friedmud, this implements your feature request discussed in #192.

One question though - are you presently calling MeshCommunication::allgather() directly from MOOSE? If so, swapping for this should be all you need. If not, then I'm guessing theres a host of optional function parameters that will need to get introduced somewhere such that under the hood the proper method gets called.

Let me know.

Owner

friedmud commented Jan 28, 2014

This looks great Ben!

We don't call this directly from MOOSE - but I'm going to have MeshSerializer in libMesh use this new function to serialize the mesh to processor 0 during solution output...

Owner

benkirk commented Jan 28, 2014

OK, I'll merge this then. I wonder if rather than assuming processor 0, if we should have MeshOutput::serial_io_rank (which defaults to 0) and then have MeshSerializer take an optional argument of the rank to serialize to?

That touches more files but is a little more flexible, and still could have MeshSerializer preserve existing behavior when called with the present API.

Owner

friedmud commented Jan 28, 2014

I was thinking of adding another argument to the constructor of MeshSerializer to tell it the rank (or invalid for all). It would default to invalid (to preserve the current behavior).

Owner

benkirk commented Jan 28, 2014

Perfect.

On Jan 28, 2014, at 12:35 PM, Derek Gaston notifications@github.com
wrote:

I was thinking of adding another argument to the constructor of MeshSerializer to tell it the rank (or invalid for all). It would default to invalid (to preserve the current behavior).


Reply to this email directly or view it on GitHub.

@benkirk benkirk added a commit that referenced this pull request Jan 28, 2014

@benkirk benkirk Merge pull request #193 from benkirk/meshcommunication_gather
MeshCommunication::gather()
cea9e03

@benkirk benkirk merged commit cea9e03 into libMesh:master Jan 28, 2014

@benkirk benkirk deleted the benkirk:meshcommunication_gather branch Jan 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment