Fixed bug in ExodusII_IO_Helper for discontinuous plots. #217

Merged
merged 1 commit into from Mar 6, 2014

Conversation

Projects
None yet
3 participants
@dknez
Member

dknez commented Mar 6, 2014

The bug was due to an indexing error in the case of multiple subdomains.

Also, DRY'd out the discontinuous vs. continuous code in ExodusII_IO_Helper.

Fixed bug in ExodusII_IO_Helper for discontinuous plots. The bug was …
…due to an indexing error in the case of multiple subdomains. Also, DRY'd out the discontinuous vs. continuous code in ExodusII_IO_Helper.
@jwpeterson

This comment has been minimized.

Show comment Hide comment
@jwpeterson

jwpeterson Mar 6, 2014

Owner

I haven't tested this out yet, but any patch that has 70 additions, 227 deletions, and fixes a bug is great in my book... if it passes the MOOSE continuous integration stuff I'd say go ahead and merge it.

Owner

jwpeterson commented Mar 6, 2014

I haven't tested this out yet, but any patch that has 70 additions, 227 deletions, and fixes a bug is great in my book... if it passes the MOOSE continuous integration stuff I'd say go ahead and merge it.

@moosebuild

This comment has been minimized.

Show comment Hide comment
@moosebuild

moosebuild Mar 6, 2014

Results of testing f108b89 using libmesh recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/166

Results of testing f108b89 using libmesh recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/166

@dknez

This comment has been minimized.

Show comment Hide comment
@dknez

dknez Mar 6, 2014

Member

hehe ok

it works for me, and it passes the moose tests, so I'll go ahead and merge. I explained what the patch does on the mailing list.

Member

dknez commented Mar 6, 2014

hehe ok

it works for me, and it passes the moose tests, so I'll go ahead and merge. I explained what the patch does on the mailing list.

dknez added a commit that referenced this pull request Mar 6, 2014

Merge pull request #217 from dknez/exodus_discontinuous_fix
Fixed bug in ExodusII_IO_Helper for discontinuous plots.

@dknez dknez merged commit 30dc26b into libMesh:master Mar 6, 2014

1 check passed

default Successfully passed all tests
Details

@dknez dknez deleted the dknez:exodus_discontinuous_fix branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment