Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osx catalina #1094

Merged
merged 2 commits into from Nov 2, 2019
Merged

fix osx catalina #1094

merged 2 commits into from Nov 2, 2019

Conversation

allefant
Copy link
Contributor

No description provided.

@allefant
Copy link
Contributor Author

Unfortunately could not find any documentation on what the update() call is supposed to do exactly, but the skater demo works again with this on OSX Catalina, including window resizing.

@elias-pschernig
Copy link
Member

Oh, and I forgot to mention, this also places the activateIgnoringOtherApps call on the main thread - which turned out to be just a harmless warning, but is still the right thing to do.

Anyway, issue #1091 seems to be fixed with this, unless we discover the original purpose of the update() call.

@elias-pschernig
Copy link
Member

Well, after figuring out the difference in objective C between @selector(update) and @selector(update:) it now does call update again, from the main thread. Should be 100% identical to before now, just works in Catalina.

@djn658
Copy link

djn658 commented Oct 29, 2019

Thank you very much! It works now. However, the display window cannot be selected. Do you happen to know how to fix it? @allefant

@mbkorecki
Copy link

Thanks a lot. It works for me as well.

@SiegeLord
Copy link
Member

Thanks for all the testing everyone, and Elias for writing this!

@SiegeLord SiegeLord merged commit 09ece37 into liballeg:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants