Fix emscripten build example for bash - #1319
Merged
Merged
Conversation
Member
|
Thanks! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expanding an array in zsh (
echo "${USE_FLAGS}") is different than in bash. zsh will expand the values as you expect, bash only the first item.When I verified this command initially I was in my zsh terminal, and only later when trying to write a bash script using the same commands did I realize (but it took a long time) the commands weren't portable.
luckily both zsh and bash do the same sensible thing for
"${USE_FLAGS[*]}"