New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined behaviour / signed integer overflow in archive_read_format_tar_skip() #548

Closed
hannob opened this Issue May 20, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@hannob
Contributor

hannob commented May 20, 2015

Using this malformed tar file with "bsdtar -tf [input]" will cause a signed integer overflow:
https://crashes.fuzzing-project.org/libarchive-undefined-signed-overflow.tar

Signed integer overflows are undefined in C. This can be seen by compiling libarchive with -fsanitize=undefined.

Here's the crash dump:
\307q\005\bo\002\244\201\350\003\350\003libarchive/archive_read_support_format_tar.c:612:10: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long'
#0 0x96c665 in archive_read_format_tar_skip /f/libarchive/libarchive/libarchive/archive_read_support_format_tar.c:612:2
#1 0x607044 in archive_read_data_skip /f/libarchive/libarchive/libarchive/archive_read.c:914:8
#2 0x515a49 in read_archive /f/libarchive/libarchive/tar/read.c:327:8
#3 0x510dbb in tar_mode_t /f/libarchive/libarchive/tar/read.c:96:2
#4 0x4feddc in main /f/libarchive/libarchive/tar/bsdtar.c:799:3
#5 0x7f183d686f9f in __libc_start_main /var/tmp/portage/sys-libs/glibc-2.20-r2/work/glibc-2.20/csu/libc-start.c:289
#6 0x442206 in _start (/f/libarchive/libarchive/bsdtar+0x442206)

SUMMARY: AddressSanitizer: undefined-behavior libarchive/archive_read_support_format_tar.c:612

bsdtar: (null)
bsdtar: Error exit delayed from previous errors.

@kientzle kientzle self-assigned this Jul 14, 2015

@kientzle kientzle modified the milestone: 3.2 Aug 1, 2015

@kientzle

This comment has been minimized.

Show comment
Hide comment
@kientzle

kientzle Aug 9, 2015

Contributor

This was fixed in 3c7a6dc

Contributor

kientzle commented Aug 9, 2015

This was fixed in 3c7a6dc

@kientzle kientzle closed this Aug 9, 2015

@petterreinholdtsen

This comment has been minimized.

Show comment
Hide comment
@petterreinholdtsen

petterreinholdtsen Jun 29, 2016

According to <URL: https://security-tracker.debian.org/tracker/CVE-2015-8933 > this is a security issue with ID CVE-2015-8933.

petterreinholdtsen commented Jun 29, 2016

According to <URL: https://security-tracker.debian.org/tracker/CVE-2015-8933 > this is a security issue with ID CVE-2015-8933.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment