Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signed integer overflow in iso parser #717

Closed
hannob opened this issue Jun 18, 2016 · 2 comments
Closed

signed integer overflow in iso parser #717

hannob opened this issue Jun 18, 2016 · 2 comments
Milestone

Comments

@hannob
Copy link
Contributor

@hannob hannob commented Jun 18, 2016

The attached malformed iso file (packed as zip, because github limits attachment file types) will cause a signed integer overflow when passed to "bsdtar -tf [infile]" (tested with libarchive 3.2.0). This can be seen with undefined behavior sanitizer (compile with -fsanitize=undefined in CFLAGS/LDFLAGS).

ubsan error:
libarchive/archive_read_support_format_iso9660.c:1094:32: runtime error: signed integer overflow: 8388631 * 2048 cannot be represented in type 'int'

This was found with the help of american fuzzy lop.
libarchive-signed-int-overflow.zip

@kientzle kientzle added this to the 3.2.1 milestone Jun 19, 2016
@kientzle
Copy link
Contributor

@kientzle kientzle commented Jun 19, 2016

I believe this is fixed in commit 3ad08e0

@kientzle kientzle closed this Jun 20, 2016
@petterreinholdtsen
Copy link

@petterreinholdtsen petterreinholdtsen commented Jun 28, 2016

According to the Debian security issue tracker, this is https://security-tracker.debian.org/tracker/CVE-2016-5844 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.