ZIP reader: fixed 2 bugs: unlimited loop and a crash, triggered by invalid files #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash happened on invalid files which declare more data than actually are stored in the file. This commit contains a fix that prevents PPMd8 decompressor from crashing, as well as relevant tests containing files that were triggering the crash.
The hang was triggered on invalid zipx files that declare more data than there actually is in the file. This case was found by fuzzing the zipx file.
antekone
force-pushed
the
bug/zipx_fuzzing_fixes
branch
from
7c23fb9
to
b94eb5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 commits on this branch: one fixes a crash in PPMd8 decompressor in ZIP reader, the second one fixes an unlimited loop in BZIP2 decompressor, also in the ZIP reader.
Files that were triggering those bugs were found during fuzzing.
For both cases I've added relevant tests with files that were triggering the bugs.