Fix bugs related to unreadable directories. #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't try to open ".." for reading as part of the process of ascending out of an initially specified directory; it's wrong, and if the directory is not readable it causes a spurious error. 2. If opening "." initially for reading fails, then open it for execute instead, if O_EXEC exists. This avoids spurious and unhelpful failures when the current directory is not readable. Add test cases for the above. At least the first of these issues is ancient; it was reported against FreeBSD in 2014.
|
The test segfaults on Mac OS X. |
|
I'm guessing that OS X lacks O_EXEC and therefore has no way to open the current directory when it is unreadable. Can you confirm that? |
If a platform lacks O_EXEC and we get a failure when starting the traverse from within an unreadable directory, then don't score that as a failure, since with the current code it can never succeed. But if O_EXEC exists, the failure still counts.
|
The two osx:mojave test failures are from your broken CI script. The autotools/freebsd12 failure looks spurious to me. |
mmatuska
approved these changes
Mar 30, 2019
|
The test now fails on Solaris-like platforms (OmniOS). The manpage for open(2) says:
|
|
On OmniOS you need to use O_SEARCH everywhere I've used O_EXEC (in the actual code, not just the test). Likewise, on Linux it should be using O_PATH. This probably means adding platform-specific configuration stuff. Since I do not have any interest in either OmniOS or Linux, I will leave that ball in your court. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to open ".." for reading as part of the process of
ascending out of an initially specified directory; it's wrong, and if
the directory is not readable it causes a spurious error.
If opening "." initially for reading fails, then open it for
execute instead, if O_EXEC exists. This avoids spurious and unhelpful
failures when the current directory is not readable.
Add test cases for the above.
At least the first of these issues is ancient; it was reported against
FreeBSD in 2014.
References issue #1166