Allow tests to pass after 2038 #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
force-pushed
the
ftbfs2038
branch
3 times, most recently
from
608ae9f
to
805edd5
Compare
|
One clarification: POSIX requires that the 12-byte field include at least one terminator character which must be space or NULL. That limits you to 33 bits (11 bytes) in a fully standards-conforming implementation. (Libarchive is willing to bend these rules, but in this particular case, I don't see any reason to go beyond 33 bits right now.) |
kientzle
reviewed
Jan 14, 2023
new deadline is 2242-03-16 https://wiki.osdev.org/USTAR documents the 12-byte octal time format that provides 12*3 = 36 bits for mtime. But apparently POSIX requires a terminator byte that reduces it to 33 bits. https://pubs.opengroup.org/onlinepubs/7908799/xcu/pax.html#tag_001_014_1700_006 Fixes libarchive#1837 This patch was done while working on reproducible builds for openSUSE.
bmwiedemann
force-pushed
the
ftbfs2038
branch
from
805edd5
to
77da185
Compare
kientzle
reviewed
Jan 14, 2023
kientzle
reviewed
Jan 14, 2023
|
Nice! Thanks for working through this so conscientously! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
new deadline is 2242-03-16
https://wiki.osdev.org/USTAR documents the 12-byte octal time format
that provides 12*3 = 36 bits for mtime.
Fixes #1837