Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlines are different with VSFilter #154

Closed
pingplug opened this issue Dec 27, 2014 · 3 comments
Closed

Outlines are different with VSFilter #154

pingplug opened this issue Dec 27, 2014 · 3 comments

Comments

@pingplug
Copy link

PlayResX and PlayResY are 848 and 480, rendered on 1280 x 720 video

Style: Default,Arial,31,&H00FFFFFF,&H00000000,&H00000000,&H00000000,-1,0,0,0,100,100,0,0,1,3,0,2,30,30,15,1
Dialogue: 0,0:00:00.00,1:00:00.00,Default,NTP,0000,0000,0000,,This is a test
Dialogue: 0,0:00:00.00,1:00:00.00,Default,NTP,0000,0000,0000,,This is a test

this is for libass
libass
this is for VSFilter
vsfilter

2015-01-03 update

  1. the outlines are different(3px in VSFilter, 4.5px in libass)
    I think this is caused by the default ScaledBorderAndShow(1 in libass, 0 in VSFilter)
  2. VSFilter add borders(top/bottom, = max border_y of the top/bottom line) between texts
    makes the collision text 6px(2 * 3px border) higher than libass
@CarVac
Copy link

CarVac commented Apr 21, 2015

It seems to be that in libass, the border widths aren't scaling with the rendering resolution.

Playing back 480p video stretched to fit my 4k screen, the borders are way too tiny: they stay the same size even as the subs themselves change size.

@grigorig
Copy link
Member

It's actually the opposite. libass scales the borders with resolution by default, VSFilter does not.

@astiob
Copy link
Member

astiob commented Mar 11, 2018

Let’s split this into #287 for ScaledBorderAndShadow and #304 for the space between events during collision detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants