Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScaledBorderAndShadow should default to “no” #287

Closed
kyuunbe opened this issue Oct 23, 2017 · 6 comments
Closed

ScaledBorderAndShadow should default to “no” #287

kyuunbe opened this issue Oct 23, 2017 · 6 comments

Comments

@kyuunbe
Copy link

@kyuunbe kyuunbe commented Oct 23, 2017

Subitle resolution: 384x288
Video resolution: 1920x1080
Style: Arial Rounded MT Bold, size=17, border=3

VSFilter (Aegisub and MPC-HC):
mpc-hc64_2017-10-22_19-55-07

libass (mpv and VLC)
mpv_2017-10-22_19-47-10

@kyuunbe
Copy link
Author

@kyuunbe kyuunbe commented Oct 23, 2017

Subitle resolution: 1280x720
Video resolution: 1920x1080
Style: Arial Rounded MT Bold, size=40, border=4, shadow=2

VSFilter (Aegisub and MPC-HC):
mpc-hc64_2017-10-22_20-35-57

libass (mpv and VLC)
mpv_2017-10-22_20-36-05

@astiob
Copy link
Member

@astiob astiob commented Oct 23, 2017

Does your script have a ScaledBorderAndShadow header?

If not, the problem is that libass currently defaults this value to “yes” whereas VSFilter defaults it to “no”, and we’re currently discussing (on IRC) how to fix this without breaking applications such as mpv and FFmpeg.

Are you the author of the script? If you are, please explicitly enable scaled border and shadow and recalculate your borders and shadows (or enable scaled border and shadow, change the PlayResX and PlayResY headers to match the video and recalculate your font sizes instead). This is easier to understand and work with, and also most compatible with old versions of libass and media players using libass (although if your script has complex sign typesetting, then old libass may be broken anyway, so this may not mean much). If you’re using Aegisub, this is controlled by a checkbox in the Script Properties window. But if you really must, you can explicitly disable scaled border and shadow by adding a ScaledBorderAndShadow: no header. (I don’t know if Aegisub does this when the checkbox is unchecked.)

@kyuunbe
Copy link
Author

@kyuunbe kyuunbe commented Oct 23, 2017

I don't fansub, I'm just a mpv user who noticed that this happens in a lot releases from different fansub groups and it starts to getting annoying when the borders are too big.

Maybe an optional parameter on mpv could fix this? (Like --disableborderandshadowscaling)

@astiob
Copy link
Member

@astiob astiob commented Mar 11, 2018

Oh, this is a duplicate of #154. I can’t decide which bug report is better, so let’s keep the older one.

@astiob astiob closed this Mar 11, 2018
@astiob
Copy link
Member

@astiob astiob commented Mar 11, 2018

On second thought, #154 contains two separate issues, so I’ll rather split it and keep this bug for the ScaledBorderAndShadow default.

@astiob astiob reopened this Mar 11, 2018
@astiob astiob changed the title Border and shadow don't scale properly when the subtitle resolution is lower than the video resolution ScaledBorderAndShadow should default to 0 Mar 11, 2018
@astiob astiob changed the title ScaledBorderAndShadow should default to 0 ScaledBorderAndShadow should default to “no” Mar 11, 2018
@astiob astiob removed the duplicate label Mar 11, 2018
TheOneric added a commit to TheOneric/libass that referenced this issue Apr 14, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 22, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 23, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 23, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 23, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 23, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 25, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 26, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 28, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 29, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 29, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 30, 2020
This is *VSFilter compatible and fixes libass#287 .
TheOneric added a commit to TheOneric/libass that referenced this issue May 30, 2020
This is *VSFilter compatible and fixes libass#287 .
@astiob astiob closed this in 5575d2f Jul 5, 2020
@avih
Copy link
Contributor

@avih avih commented Jul 11, 2020

FWIW, this commit made the OSD outline in mpv very thin, and subjectively too thin IMHO. See mpv-player/mpv#7900 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants