From 90621db989879c36de750a462e2078a3b8091c61 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Mon, 23 Mar 2026 21:42:44 -0400 Subject: [PATCH 1/2] Comments. --- src/protocols/protocol_electrum.cpp | 1 + test/protocols/electrum/electrum_transactions.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/protocols/protocol_electrum.cpp b/src/protocols/protocol_electrum.cpp index 8555c062..ba2df763 100644 --- a/src/protocols/protocol_electrum.cpp +++ b/src/protocols/protocol_electrum.cpp @@ -474,6 +474,7 @@ void protocol_electrum::handle_blockchain_transaction_get(const code& ec, const auto size = tx->serialized_size(true); if (verbose) { + // TODO: inject contextual tx properties. // Verbose means whatever bitcoind returns for getrawtransaction, lolz. send_result(value_from(bitcoind(*tx)), two * size, BIND(complete, _1)); } diff --git a/test/protocols/electrum/electrum_transactions.cpp b/test/protocols/electrum/electrum_transactions.cpp index 63a11d96..7ec1a50c 100644 --- a/test/protocols/electrum/electrum_transactions.cpp +++ b/test/protocols/electrum/electrum_transactions.cpp @@ -126,6 +126,7 @@ BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verb BOOST_CHECK_EQUAL(response.at("result").as_string(), encode_base16(coinbase.to_data(true))); } +// TODO: the expectation doesn't acocunt for contextual tx properties. BOOST_AUTO_TEST_CASE(electrum__blockchain_transaction_get__genesis_coinbase_verbose_true__expected) { BOOST_CHECK(handshake()); From b19e9ba63006b8e8b44f2227d48a9788013426da Mon Sep 17 00:00:00 2001 From: evoskuil Date: Tue, 24 Mar 2026 19:15:14 -0400 Subject: [PATCH 2/2] Change currency_window_minutes default text to 1440. --- src/parser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parser.cpp b/src/parser.cpp index db14b615..6da93d9b 100644 --- a/src/parser.cpp +++ b/src/parser.cpp @@ -1328,7 +1328,7 @@ options_metadata parser::load_settings() THROWS ( "node.currency_window_minutes", value(&configured.node.currency_window_minutes), - "Time from present that blocks are considered current, defaults to '60' (0 disables)." + "Time from present that blocks are considered current, defaults to '1440' (0 disables)." ) // ####################### ////(