Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package #789

Merged
merged 12 commits into from Aug 1, 2022
Merged

NuGet package #789

merged 12 commits into from Aug 1, 2022

Conversation

simon-berger
Copy link
Contributor

@simon-berger simon-berger commented Jul 18, 2022

Work in progress!

Do not merge.

Issue

Close #297

TODOs

  • Locally create working package
  • Automate package generation (CI)
  • (Automated) publishing of the created package
  • Fix uploaded version of 1.9.0
  • Update Readme

Description

Because of the poor documentation from Microsoft, I mainly used this manual as a guide: link
With this, I managed to create a native NuGet package which automatically gets created from a CI job if a new release tag is created. The created package is then uploaded as a job artifact and published to NuGet.org.
Here is an example of the CI action with an working package build: example CI run

@simon-berger
Copy link
Contributor Author

simon-berger commented Jul 20, 2022

I have successfully created a CI job which automatically creates the NuGet package and uploads the result as an artifact (example run) 🎉 .
The next step would be to (automatically) publish the package (if intended) to NuGet.org, for which I would need a NuGet account and API key (How to publish).
Moreover we maybe need to change certain metadata in the .nuspec file (e.g. Who should be the authors/owners?).

@COM8 can you please please briefly check the metadata and let me know if you want the package to be published.

Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good.

.github/workflows/build-nuget.yml Show resolved Hide resolved
nuget/libcpr.nuspec Outdated Show resolved Hide resolved
@COM8
Copy link
Member

COM8 commented Jul 20, 2022

In my eyes it makes sense the you use an API-Key I provide as "libcpr" to make sure we can even in the future change stuff if required directly.

@COM8
Copy link
Member

COM8 commented Jul 20, 2022

I have created an account for nuget@libcpr.org. Like for the .deb package I can forward all mail arriving there to you in case you are interested.

@COM8 COM8 added this to the CPR 1.9.x milestone Jul 25, 2022
@simon-berger
Copy link
Contributor Author

I completed testing with this fresh package.

@simon-berger simon-berger marked this pull request as ready for review July 26, 2022 10:37
@simon-berger simon-berger requested a review from COM8 July 26, 2022 10:37
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks.

@COM8 COM8 merged commit e43aeb7 into libcpr:master Aug 1, 2022
COM8 added a commit that referenced this pull request Aug 1, 2022
@COM8
Copy link
Member

COM8 commented Aug 1, 2022

The CI worked perfectly: https://www.nuget.org/packages/libcpr/#versions-body-tab

@simon-berger
Copy link
Contributor Author

Just got the email, perfect 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make a NuGet package. That can help add your library to project easier
2 participants