New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to badge at shields.io #1103

Closed
mattbk opened this Issue May 15, 2018 · 12 comments

Comments

3 participants
@mattbk
Contributor

mattbk commented May 15, 2018

Currently:
image

Suggestion from https://twitter.com/l33tname/status/996052539014598656:

I found that but they look confusing and don't include the logo or the color

@fliiiix

This comment has been minimized.

fliiiix commented May 15, 2018

Thanks for opening a ticket my main problem with these buttons is that it's not clear that they are for Liberapay. They way they look they could be basically for many different platforms. So it would be cool if the looked more like this: Donate

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 16, 2018

This looks pretty simple based on badges/shields#1413 and then adding e.g. ?logo=liberapay to the path.

Logos go here: https://github.com/badges/shields/tree/gh-pages/logo. Looks like the Liberapay SVG is at https://github.com/liberapay/liberapay.com/blob/8709f4543e78ef148d56bb0009aee1a735fe8fac/www/assets/liberapay/icon-v2_yellow-r.svg.

For example, with the Discord logo (for no reason at all):

image

<img src="https://img.shields.io/liberapay/receives/Changaco.svg?logo=discord">

We can also change the left side of the shield to the Liberapay yellow (#f6c915).

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 16, 2018

Some ideas. I may drop the background yellow on the logo.

image

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 16, 2018

Without background color on logo:

image
image
image
image

With colored logo:
image
image
image
image

@mattbk mattbk referenced this issue May 16, 2018

Merged

Add Liberapay logo #1692

1 of 1 task complete
@Changaco

This comment has been minimized.

Member

Changaco commented May 17, 2018

The yellow on yellow ones look weird, but I like the others.

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 18, 2018

Feedback from @fliiiix on Twitter:

Can not login on github at the moment but I personaly prefere the first ones:
https://user-images.githubusercontent.com/3729038/40136266-0311521c-590d-11e8-8be0-e1c3af38acf7.png https://twitter.com/l33tname/status/996872045089697794

text black on white but the logo in color I think making the entire badge yellow is a bit too much https://twitter.com/l33tname/status/996872311482568705

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 18, 2018

I'll roll with the white/yellow logo on black and we can change in the future.

@mattbk

This comment has been minimized.

Contributor

mattbk commented May 21, 2018

The PR has been committed, we're just waiting on deployment (which does not happen very often.)

To show the logo, code would be:
<img src="https://img.shields.io/liberapay/receives/Changaco.svg?logo=liberapay">

@fliiiix

This comment has been minimized.

fliiiix commented Jun 3, 2018

Yay, it looks like it's deployed but it seems that now it always shows invalid.

2018-06-03--1528026784_3840x1080

@Changaco

This comment has been minimized.

Member

Changaco commented Jun 3, 2018

@fliiiix That was due to the requests from Shields being blocked because we're currently in "Under Attack" mode, I've adjusted the settings to correct the problem.

@Changaco

This comment has been minimized.

Member

Changaco commented Jun 3, 2018

I believe this issue can be closed now. Good work @mattbk! 🙂

@Changaco Changaco closed this Jun 3, 2018

@fliiiix

This comment has been minimized.

fliiiix commented Jun 3, 2018

🎉 Amazing 🎉 thank you @mattbk & @Changaco ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment