Make TestFunction less eager to look up data#252
Merged
Conversation
Previously when a `TestFunction` instance was created it tried to eagerly look up the data it needs from the corresponding `Function` instance, but now it just stores the `Function` and the required data is looked up from the `Function` when it is needed. This reduces the number of `TestFunction` attributes and the `TestFunction.from_function()` class method is no longer needed at all.
avalentino
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current
mainwhen aTestFunctioninstance is created it tries to eagerly look up the data it needs from the correspondingFunctioninstance, but in this PR it just stores theFunctionand the required data is looked up from theFunctionwhen it is needed. This reduces the number ofTestFunctionattributes and theTestFunction.from_function()class method is no longer needed at all.