Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ':' in password #50

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Allow ':' in password #50

merged 1 commit into from
Oct 20, 2018

Conversation

benrubson
Copy link
Contributor

Hi,

This PR corrects a bug where : is not allowed in passwords.
(it replaces libertempo/web#723)

Thank you 👍

@benrubson benrubson mentioned this pull request Oct 12, 2018
Closed
prytoegrian
prytoegrian approved these changes Oct 20, 2018
View reviewed changes
Copy link
Member

@prytoegrian prytoegrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@prytoegrian prytoegrian merged commit 2605105 into libertempo:master Oct 20, 2018
@benrubson benrubson deleted the benrubson-password branch October 20, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prytoegrian prytoegrian prytoegrian approved these changes

Assignees
No one assigned
Labels
Amélioration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benrubson @prytoegrian