Display the vacation category

[benrubson]

Hi,

This PR allows to display the vacation category, which is really convenient :

Thus it closes #501.
It also helps answering #488, #609, #709 (and some others).

Thank you 👍

[wouldsmina]

for this PR, we will have to discuss it. I consider this information should not be visible by colleagues, especially sick leave.

Why is leave type not enough? Or maybe this need is limited to managers and HR?

[benrubson]

Sometimes, company size is small enough for this info to be shared between the employees.
They then deliberately want to make the vacation category "public", which becomes a useful piece of info for everyone.

Perhaps we could add a knob to enable/disable this, if you think some may not want this ?
Or perhaps allow different levels :

• off
• managers & HR
• everyone

[prytoegrian]

As you may have seen the several conversations about it, we tried our best to stick to the laws, keeping employee privacy in mind ; for theses reasons we decided to display a neutral appearance for leaves, and only managers may see full informations.
As with the calendar in 1.9, users didn't like it but we always try to do the best choice and sometimes Law requires something that bothers us. In that precise case, perhaps your proposition is the best option, with the good balance between privacy and flexibility for small structure. Often, I try to avoid adding options above options in the settings panel but if this one is justified...

Currently, rules are :

• managers, HR and admin only can see leaves that have not been validated yet (https://github.com/libertempo/web/blob/develop/calendrier.php#L10),
• an employee can see another employee's leaves only if both share a group (https://github.com/libertempo/web/blob/develop/calendrier.php#L57),
• only a neutral category is displayed (Cf. your code).

So, a toggle might be cool with :

• off
• managers & HR
• manager & HR + group
• everyone

Obviously, neutral terms are kept for users in others ensembles.

I let you consult this PR #342 for example.

@wouldsmina @benrubson what do you think ?

[ttaduy]

Would it be possible to display on the calendar "vacations" (congés) and "Work From Home" (Télétravail) ?
For the moment, the members of the same team are not able to know if his co-worker is on vacations or working from home.

[benrubson]

Would it be possible to display on the calendar "vacations" (congés) and "Work From Home" (Télétravail) ?

This patch will, it simply takes the label from every existing vacation category 👍

[benrubson]

@wouldsmina @benrubson what do you think ?

Lets' then merge this PR, as, as you mentioned, it only displays a neutral category, which is rather a good balance between privacy and flexibility for small structure ? In addition, as vacation categories can be configured, they can be as neutral, or as precise as the structure wants...
As a second step perhaps, if some users ask for, we could think about adding an option to show the detailed vacation reason to one the the 4 groups described in your post above.

[wouldsmina]

Would it be possible to display on the calendar "vacations" (congés) and "Work From Home" (Télétravail) ?

Interesting argument, I understand the need better...

[wouldsmina]

@wouldsmina @benrubson what do you think ?

Good idea, but "off" option is not necessary, HR and managers need this information.

[ttaduy]

Interesting argument, I understand the need better...

In the case of "WFH", it means this person is working and can be reached, unlike the case of "Vacations".

[prytoegrian]

It seems like we don't agree on « neutral category ». Do you mean the general type ? For me, as long as it displays the leave category, Libertempo doesn't protect the employee privacy, that's why I proposed this toggle, since I recognize the user need.

As a second step perhaps, if some users ask for, we could think about adding an option to show the detailed vacation reason to one the the 4 groups described in your post above.

Like me, you know the user never asks for more and more barriers, as they slow him down. Then, one day, something like GDPR appears and you're asked why, as an editor, you didn't code « privacy by design ».

But, if all of you share this opinion, I'll bend to it and we will do it in two steps 👍

[benrubson]

Do you mean the general type ?

I meant ta_libelle field of conges_type_absence table (as in this PR) as a "neutral" category.
p_commentaire field of conges_periode being a much more precise vacation reason.
But I first did not understand you meant ta_type of conges_type_absence table as the neutral category... My mistake.

Don't know then if we can go in 2 steps, or if we must implement the toggle option.
However not sure I'll have time for now to develop the toggle...

[benrubson]

Do you think we could see this in 1.12, if we are all OK ?
Thank you !

[prytoegrian]

Do you think we could see this in 1.12

Actually, we are building it, develop is 1.12, but it doesn't really change your idea.
I'm thinking about it, particularly what image is sent if we change a functionnality in one version, and again in the next one. At this moment, i would prefer deliver a finished model but

• 1.12 beta is about to be released,
• I can't estimate the loss of not having the vacation category right now

[prytoegrian]

Our beta is about to be released (tomorrow or sunday) and I wouldn't like to rush to merge this expected functionnality. So, I pushed an idea in our very new feedback system : https://feedback.libertempo.fr/home/idea/5/afficher-la-catgorie-d-absence-dans-le-calendrier. This new tool will helps us to sort yours issues.

I wrote your toggle proposition, but obviously the debate is still open. Once we'll agree, together, I'll be more confident to start and merge the dev.

PS : Sorry, there's no line break 😭 , I'm waiting the merge of the correction phpback/phpback#149.

[benrubson]

You're absolutely right @prytoegrian, let's take time to fully implement this, correctly.
And thank you for your time 👍

[prytoegrian]

This issue is the very first one in feedback, we'll do it in Nooma (1.13).

[wouldsmina]

This issue is the very first one in feedback, we'll do it in Nooma (1.13).

yes, but I insist that it's necessary, at least initially, to limit this information to managers and HR. You can do it simply by testing $canVoirEnTransit in Evenements.php:95

[benrubson]

Perhaps @prytoegrian was already thinking about the toggle option discussed above as the solution to be implemented in Nooma (1.13) 😃

[prytoegrian]

@wouldsmina : Hum, I wasn't very precise, sorry. I meant this topic will be addressed in Nooma, obviously we'll not merge this PR as is. The business rules applied are described in https://feedback.libertempo.fr/home/idea/5/afficher-la-catgorie-d-absence-dans-le-calendrier
Does this version is convenient to you ?

[wouldsmina]

https://feedback.libertempo.fr/home/idea/5/afficher-la-catgorie-d-absence-dans-le-calendrier
Does this version is convenient to you ?

Ok, let's go! :)

@benrubson you can do it?

[benrubson]

Not sure I'll have time for now to work on this unfortunately :-/

[wouldsmina]

remplacé par #807 👍