Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross platform filemap + remove debugging dialog box #7

Merged
merged 4 commits into from Jul 30, 2014
Merged

Cross platform filemap + remove debugging dialog box #7

merged 4 commits into from Jul 30, 2014

Conversation

uyjulian
Copy link
Contributor

@uyjulian uyjulian commented Jul 30, 2014

Now works on mac with just Mono (no wine required!)
Linux and Windows haven't been tested yet (because it's 12 am right here right now, and I'm running on battery so I can't run my VM right now)

@Sammi-Husky
Copy link
Collaborator

Sammi-Husky commented Jul 30, 2014

Unfortunately, this does break the windows version beyond usability so we will have to hold this off until it's workable :/ Incidentally, was this tested beyond it compiling correctly?

@uyjulian
Copy link
Contributor Author

uyjulian commented Jul 30, 2014

Yes, I tested on Mac, haven't tested on Linux yet.
I'll add the windows-specific code back in.

@Sammi-Husky
Copy link
Collaborator

Sammi-Husky commented Jul 30, 2014

Awesome, that fixed the issues. Now the last thing to do is test linux, and this can be safely merged :) good stuff

@uyjulian
Copy link
Contributor Author

uyjulian commented Jul 30, 2014

Okay, Linux has been tested.
All good!

@Sammi-Husky
Copy link
Collaborator

Sammi-Husky commented Jul 30, 2014

Alrighty! Nice work!

Sammi-Husky added a commit that referenced this pull request Jul 30, 2014
Cross platform filemap + remove debugging dialog box
@Sammi-Husky Sammi-Husky merged commit 1f1851f into libertyernie:master Jul 30, 2014
libertyernie pushed a commit that referenced this pull request Jun 9, 2018
Updated BrawlBox Master Branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants