"accept()" is not supported

[azat]

If errno is ENOSYS - just return from loop

As the man a accept(2) says:

The accept4() system call is available starting with Linux 2.6.28; support in glibc is available starting with version 2.10

[nmathewson]

It looks like this change would be better made in evutil_accept4_(), and the code should have it fall back to accept() rather than failing entirely. Have a look at branch 21_accept4_enosys in the nmathewson/libevent github repository?

[azat]

@nmathewson yes it fix accept4() call if it is not supported
But as I understand listener.c:listener_read_cb still retying to read, but it is not right, because it never ends

[nmathewson]

If evutil_accept4_() fails, it will return a negative value, so new_fd will be less than 0, so the code
{{{
if (new_fd < 0)
break;
}}}
will break out of the loop.

Am I missing something?

[azat]

Yes, this is event is retrying to read again after error, it means that this callback called again after error

So commit like this azat/libevent@2be0338 doesn`t helps me

Your patch is needed too

[azat]

In fact that commit (first in this pull request) is written because of my inattention

[nmathewson]

But with the patch I wrote, ENOSYS can't occur, since if accept4() returns ENOSYS, the evutil_accept4_ function will immediately try accept(). So detecting ENOSYS in listener.c should be unnecessary, unless accept() can also return ENOSYS. Is there some other error you're thinking of here?

[azat]

Sorry, my mistake. You right