Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link against libm for function "isnan" (fixes #509) #510

Merged
merged 2 commits into from Sep 20, 2021
Merged

Link against libm for function "isnan" (fixes #509) #510

merged 2 commits into from Sep 20, 2021

Conversation

hartwork
Copy link
Member

@hartwork hartwork commented Sep 8, 2021

Fixes #509

To test with GNU Autotools, locally:

cd "$(mktemp -d)"
git clone --branch issue-509-link-against-libm --depth 1 https://github.com/libexpat/libexpat
cd libexpat/expat/
./buildconf.sh && ./configure && make all check

To test with CMake, locally:

cd "$(mktemp -d)"
git clone --branch issue-509-link-against-libm --depth 1 https://github.com/libexpat/libexpat
cd libexpat/expat/
cmake . && make VERBOSE=1 all test

@hartwork hartwork mentioned this pull request Sep 8, 2021
Closed
@hartwork hartwork force-pushed the issue-509-link-against-libm branch 6 times, most recently from 5b78d8d to 6ae5333 Compare September 10, 2021 15:20
@hartwork hartwork mentioned this pull request Sep 11, 2021
Closed
@hartwork
Autotools|CMake: Link against libm for function "isnan"
0b7a88b 
$ git --no-pager grep -lw isnan
lib/xmlparse.c
tests/runtests.c
xmlwf/xmlwf.c
@hartwork hartwork merged commit 72d7ce9 into master Sep 20, 2021
@hartwork hartwork deleted the issue-509-link-against-libm branch September 20, 2021 17:21
@hartwork hartwork mentioned this pull request Sep 23, 2021
Closed
@pablogsal pablogsal mentioned this pull request Sep 29, 2021
Merged
hartwork added a commit that referenced this pull request Oct 17, 2021
@hartwork
Get attribution headers back in sync
c3300c9 
Follow-up to pull requests #503 and #510
@hartwork hartwork added this to the 2.4.2 milestone Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug compilation
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.

Link error "Undefined symbol: ._isnanf" on AIX
1 participant
@hartwork