-
Notifications
You must be signed in to change notification settings - Fork 459
[CVE-2022-23990] lib: Prevent integer overflow in function doProlog #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75761d4 to
89c54a3
Compare
|
Got |
The change from "int nameLen" to "size_t nameLen" addresses the overflow on "nameLen++" in code "for (; name[nameLen++];)" right above the second change in the patch.
89c54a3 to
6e34495
Compare
|
Looks good to me, same pattern as everywhere else. the data types are consistently |
|
@rillig thanks for the review! 👍 |
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/poky
that referenced
this pull request
Mar 9, 2022
Source: https://github.com/libexpat/libexpat MR: 115289 Type: Security Fix Disposition: Backport from libexpat/libexpat#551 ChangeID: d95b360ccd5b3cce4e8bcc4a279b660cefed197c Description: CVE-2022-23990 expat: integer overflow in the doProlog function Signed-off-by: Vijay Anusuri <vanusuri@mvista.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
jpuhlman
pushed a commit
to MontaVista-OpenSourceTechnology/poky
that referenced
this pull request
Apr 6, 2022
Source: libexpat/libexpat#551 MR: 115285 Type: Security Fix Disposition: Backport from libexpat/libexpat#551 ChangeID: 52032b80970b3a40e5c34198dabf8b72e46c3e26 Description: lib: Prevent integer overflow in doProlog (CVE-2022-23990) The change from "int nameLen" to "size_t nameLen" addresses the overflow on "nameLen++" in code "for (; name[nameLen++];)" right above the second change in the patch. Signed-off-by: vivek kumbhar <vkumbhar@mvista.com> Reviewed-by: Jeremy Puhlman <jpuhlman@mvista.com> Signed-off-by: Jeremy A. Puhlman <jpuhlman@mvista.com>
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The related code has been introduced by commit cb8a4c7 about 20 years ago.
A CVE has been requested from Mitre just now.
CC @rillig