Freebsd #189
Merged
Freebsd #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, thanks a lot! Much appreciated. |
Nikratio
reviewed
Aug 3, 2017
There was a problem hiding this comment.
I'm confused by this patch. As far as I can tell, it does almost no change to the semantics. Its only effect is to prevent subtype from being passed through. The rest just introduces fsname in several function and variable names. Note especially that the add_default_fsname function is identical to add_default_subtype. Should line 179 maybe changed to -ofsname=%s?
Am I missing something?
|
...where "this patch" is the "Support fsname= option" commit. |
Nikratio
reviewed
Aug 3, 2017
| @@ -92,7 +92,10 @@ thread_dep = dependency('threads') | |||
| # | |||
| # Read build files from sub-directories | |||
| # | |||
| subdirs = [ 'lib', 'include', 'util', 'example', 'doc', 'test' ] | |||
| subdirs = [ 'lib', 'include', 'example', 'doc', 'test' ] | |||
| if not host_machine.system().startswith('freebsd') | |||
There was a problem hiding this comment.
Are you sure this works? According to http://mesonbuild.com/Reference-manual.html#build_machine-object the test should be host_machine.system() == 'bsd'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream FreeBSD changes and fix build with meson