This repository has been archived by the owner on May 26, 2022. It is now read-only.
Forward file locking requests to the sftp server #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion flock@openssh.com.
Nikratio
force-pushed
the
master
branch
2 times, most recently
from
4b1b5c6
to
3ade813
Compare
|
Thanks for working on this! This looks like a great feature to have, please keep me posted on progress on the protocol. |
Nikratio
force-pushed
the
master
branch
4 times, most recently
from
8ef0a05
to
bc47eeb
Compare
|
Since the protocol extensions was rejected by the sftp-server team (see openssh/openssh-portable#66), we will have to close this pull request as well. |
|
We found an issue with this change; connection to servers without the flock extensions results in ENOSYS being returned for every flock() system call. It would be preferable to use the old behavior that uses kernel locking implementation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This patch intercepts flock(2) system calls and forwards them to the remote host. The SFTP protocol extension is documented at openssh/openssh-portable#66 .
Do not merge this pull request until the protocol is finalized by being merged into openssh.