testing against a installed GD library fails

[fila43]

Hi,
I was trying to test installed GD 2.3.0 and after running make it ended up with :

Building C object tests/gdtest/CMakeFiles/gdTest.dir/gdtest.c.o
/root/rpmbuild/BUILD/libgd-2.3.0/tests/gdtest/gdtest.c: In function ‘_clean_dir’:
/root/rpmbuild/BUILD/libgd-2.3.0/tests/gdtest/gdtest.c:82:2: error: unknown type name ‘DIR’
82 | DIR *d;
| ^~~

after fix missing types I got:

[ 98%] Linking C executable ../Bin/gif
/usr/bin/ld: CMakeFiles/gif.dir/gif.c.o: in function main': /tmp/libgd-gd-2.3.0/examples/gif.c:14: undefined reference to gdImageCreate'
/usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:26: undefined reference to gdImageColorAllocate' /usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:27: undefined reference to gdImageGifAnimBegin'
/usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:31: undefined reference to gdImageCreate' /usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:36: undefined reference to gdImageColorAllocate'
/usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:37: undefined reference to gdImageColorAllocate' /usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:39: undefined reference to gdImageFilledRectangle'
/usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:40: undefined reference to gdImageGifAnimAdd' /usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:43: undefined reference to gdImageDestroy'
/usr/bin/ld: /tmp/libgd-gd-2.3.0/examples/gif.c:48: undefined reference to `gdImageGifAnimEnd'
collect2: error: ld returned 1 exit status

I wrote a simple patch which works for me.

[willson-chen]

Hi @fila43, thanks for your feedback.

Here is your patch:

Fix problems with testing against installed GD library

--- libgd-gd-2.3.0/CMakeLists.txt	2020-03-22 14:40:02.000000000 +0100
+++ ../libgd-gd-2.3.0/CMakeLists.txt	2020-08-10 11:04:59.670292207 +0200
@@ -56,11 +56,18 @@
 	INCLUDE_DIRECTORIES(BEFORE ${GD_INCLUDE_DIR})
 	FIND_PACKAGE(GD)
 	if (GD_FOUND)
-		INCLUDE_DIRECTORIES(BEFORE ${GD_INCLUDE_DIR})
+		INCLUDE_DIRECTORIES(BEFORE ${GD_INCLUDE_DIR} ${GD_SOURCE_DIR}/src/ )
 		LINK_DIRECTORIES(${GD_LIBRARIES})
 		SET(GD_LIB ${GD_LIBRARIES})
 		SET(GD_LIBS_DIR ${GD_LIBRARY})
 
+		add_compile_definitions(HAVE_DIRENT_H)
+		add_compile_definitions(HAVE_UNISTD_H)
+		add_compile_definitions(HAVE_SYS_STAT_H)
+		add_compile_definitions(HAVE_SYS_TYPES_H)
+
+		SET(BUILD_SHARED_LIBS TRUE)
+
 		message("GD libs #: ${GD_LIBRARIES}")
 		message("GD lib #: ${GD_LIBRARY}")
 		message("GD include: ${GD_INCLUDE_DIR}")

I wonder why you set BUILD_SHARED_LIBS, which is true by default.

And could you please offer your build environment information, such as cpu arch and os type?

[fila43]

I was wondering how to enable testing against the already installed library. And without setting up BUILD_SHARED_LIBS to TRUE build fails because the build of examples fails on missing library during linking.

Build was made on Fedora with hw

[pierrejoye]

I think we should drop this and use binding or other projects tests suites to valid BC.

Thoughts?

@vapier @cmb69 @willson-chen

[vapier]

I don't think running source tests against an installed library is that common. I'm not sure I've really seen it done before. if it's easy to pull off, I'm not against it, but the proposed patch won't cut it.

so I'm ok with just letting this feature request go.

not sure what you mean by "BC".

[pierrejoye]

Backwards compatibility, for example 2.3.2 vs 2.3.3 APIs and ABIs BC.

…

On Fri, Sep 3, 2021, 12:10 AM Mike Frysinger ***@***.***> wrote: I don't think running source tests against an installed library is that common. I'm not sure I've really seen it done before. if it's easy to pull off, I'm not against it, but the proposed patch won't cut it. so I'm ok with just letting this feature request go. not sure what you mean by "BC". — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#652 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACE6KCLDGWKD4AK6XDJOS3T76VXRANCNFSM4PZZCQ2Q> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[vapier]

we should integrate https://lvc.github.io/abi-compliance-checker/ for that kind of coverage. we should be able to get it into our CI to make sure it doesn't break.