You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
Two previous issues #247 and #697, show that a return value check for gdGetBuf is necessary and it can cause read out of bound with a corrupted TGA file.
gdPutBuf is similar to gdGetBuf and it also shows the error condition in its return value.
some usages for gdPutBuf are comparing return values to see any error occurred or not. (in gd_jpeg.c and gd_gd2.c)
but there are some other call sites that do not check the return value and also the passed arguments are tainted and can be corrupted.
this is the list of them:
Activity
Partial fix for #750
Merge pull request #755 from libgd/bug/750
pierrejoye commentedon Sep 8, 2021
Partial fix applied for BMP and WebP. For GIF, a lot of refactoring is needed and I am not sure it is worth it. What do you think?
We can open a separate issue for GIF as it also requires ABI/API breaks for what I see.