New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default gitignore is too restrictive #4560
Comments
Sure, PR welcome, let's keep it at one master .gitignore though
…----- Reply message -----
From: "mgsx-dev" <notifications@github.com>
To: "libgdx/libgdx" <libgdx@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Subject: [libgdx/libgdx] Default gitignore is too restrictive (#4560)
Date: Tue, Jan 24, 2017 10:07
gitignore file generated by gdx setup have undesirable side effects : any folder you want to track with git (including java package) which is named "war", "build", "out" or "bin" will be ignored. Note that I discovered this issue creating a "war" game with a "war" package name somewhere, so other developers may face the same problem.
IMO best practice is to avoid recursive path in gitignore as much as possible (all path without a leading slash are processed recursively).
My proposal would be to keep some global recursive ignore in the root file (*.class, *.project ...) and dispatch specific parts to related sub-project : For instance, "war/" would be replaced by "/war" and moved to web sub-project.
What do you think ?
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/libgdx/libgdx","title":"libgdx/libgdx","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/libgdx/libgdx"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Default gitignore is too restrictive (#4560)"}],"action":{"name":"View Issue","url":"#4560"}}}
|
mgsx-dev
added a commit
to mgsx-dev/libgdx
that referenced
this issue
Jan 30, 2017
7 tasks
MrStahlfelge
pushed a commit
to MrStahlfelge/gdx-setup
that referenced
this issue
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gitignore file generated by gdx setup have undesirable side effects : any folder you want to track with git (including java package) which is named "war", "build", "out" or "bin" will be ignored. Note that I discovered this issue creating a "war" game with a "war" package name somewhere, so other developers may face the same problem.
IMO best practice is to avoid recursive path in gitignore as much as possible (all path without a leading slash are processed recursively).
My proposal would be to keep some global recursive ignore in the root file (*.class, *.project ...) and dispatch specific parts to related sub-project : For instance, "war/" would be replaced by "/war" and moved to web sub-project.
What do you think ?
The text was updated successfully, but these errors were encountered: