New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ImageTextButton to have image and label on separate rows #1110

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pyko

pyko commented Dec 21, 2013

ImageTextButton allows you to create button where the image and label are on the same row (image left, label right).

Added functionality to allow the image and label to be on separate rows (image top, label below)

@NathanSweet

This comment has been minimized.

Show comment
Hide comment
@NathanSweet

NathanSweet Dec 21, 2013

Member

You can do this outside of the ImageTextButton:

button.clearChildren();
button.add(button.getImage()).row();
button.add(button.getLabel());

I think I prefer this over making it a configurable option, as there are other configurations (eg, label then image, label then image on next row, etc) and fewer config options is better.

Member

NathanSweet commented Dec 21, 2013

You can do this outside of the ImageTextButton:

button.clearChildren();
button.add(button.getImage()).row();
button.add(button.getLabel());

I think I prefer this over making it a configurable option, as there are other configurations (eg, label then image, label then image on next row, etc) and fewer config options is better.

@pyko

This comment has been minimized.

Show comment
Hide comment
@pyko

pyko Dec 21, 2013

Oh nice! Didn't know you can do that.

Bit obscure/hard to find, but definitely more flexible.

Agree that fewer config options are better.

pyko commented Dec 21, 2013

Oh nice! Didn't know you can do that.

Bit obscure/hard to find, but definitely more flexible.

Agree that fewer config options are better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment