merged old and new PolygonRegionLoader

[dermetfan]

Didn't want to break API with my second PR, but since you agreed in #1602, I do it in the third.

[badlogic]

Curious, why would that break the API?

[dermetfan]

Some people might have used the old PolygonRegionLoader. Like for example the new PolgyonRegionLoader originally did. Since I wrote it for libgdx-utils, I couldn't just merge it with the existing one. If anyone did something similiar, it's now broken.

[MobiDevelop]

I probably would have left it in its original location. Then it wouldn't have broken anything for anyone.

[badlogic]

On 09.04.14 22:57, MobiDevelop wrote:

I probably would have left it in its original location. Then it
wouldn't have broken anything for anyone.

—
Reply to this email directly or view it on GitHub
#1665 (comment).

ya, moving it there.

[dermetfan]

Keeping an AssetLoader in graphics.g2d instead of assets.loaders does not seem right to me though. That would mess things up IMO

[badlogic]

On 09.04.14 22:59, Robin S wrote:

Keeping an AssetLoader in graphics.g2d instead of assets.loaders does
not seem right to me though. That would mess things up IMO

—
Reply to this email directly or view it on GitHub
#1665 (comment).

Nope, that's fine. Moving a class to another package breaking people's
code is messing things up.

[MobiDevelop]

Why is that? The TiledMap loaders are in the maps package.

[dermetfan]

@badlogic, moving it there won't be enough. It also needs a non-arg constructor like the old PolygonRegionLoader had.
@MobiDevelop Why do we even have an assets.loaders package then? One system should be enough. Putting them all in their according packages or keeping them in one place sounds better to me.

[MobiDevelop]

To me, it depends on whether the loader is strictly for use with the AssetManager. The map loaders, and this loader are not, so they belong in the respective package (in my opinion).

[dermetfan]

Fair enough. That's also a reasonable guideline.