Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSimple changes to the math package for convenience #2018
+269
−25
Conversation
This comment has been minimized.
This comment has been minimized.
I think it makes reviewing PRs a lot easier if the one creating the PR writes a quick summary about what the changes are, why they were made and which use cases they cover. With this quick overview in mind it is much easier for the reviewer to understand your changes. |
This comment has been minimized.
This comment has been minimized.
Gotcha. Will do right now. EDIT: Done. |
This comment has been minimized.
This comment has been minimized.
Cool, thanks! |
badlogic
added a commit
that referenced
this pull request
Jun 25, 2014
Simple changes to the math package for convenience
This comment has been minimized.
This comment has been minimized.
RotaruDan
commented on gdx/src/com/badlogic/gdx/math/Rectangle.java
in 9740a54
Jun 25, 2014
2 * (w + h) ? |
This comment has been minimized.
This comment has been minimized.
of course |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JesseTG commentedJun 22, 2014
This is mostly for me to get my feet wet in contributing to LibGDX. I haven't done many pull requests before.
Anyway, this PR is nothing huge. It just does the following:
equals()
andhashCode()
toCircle
,Ellipse
,GridPoint2
,GridPoint3
,Ray
,Segment
, andSphere
.Circle
,Ellipse
,Sphere
, andRectangle
Rectangle
's uses ofNumberUtils.floatToIntBits()
toNumberUtils.floatToRawIntBits()
.len()
andlen2()
toSegment
Ellipse
that accepts aCircle
(not vice versa)I don't believe this is a breaking change (sans the usual negligible probabilities that come with changing the hash function).