set empty Gdx.* fields and made get[Component]() methods work in headless backend #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeadlessApplication#get[Input/Graphics/Audio]() returned null even though HeadlessApplication had mock implementations. Correct me if I'm wrong, but I guess this was because the getters were forgotten when those mock implementations were added. I don't think they returned null intentionally because the Gdx.[audio/graphics] fields were set (Gdx.input not though, so it seems it was forgotten as well).
dermetfan
changed the title
|
Seems reasonable. Thanks. |
MobiDevelop
added a commit
that referenced
this pull request
Sep 9, 2014
set empty Gdx.* fields and made get[Component]() methods work in headless backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeadlessApplication#get[Input/Graphics/Audio]()returned null even thoughHeadlessApplicationhad corresponding mock implementations.Correct me if I'm wrong, but I guess this was because the getters were forgotten when those mock implementations were added.
I don't think they returned null intentionally because the
Gdx.[audio/graphics]fields were set (Gdx.inputwasn't though, so it seems it was forgotten as well).