Updated clamp method

[jacobrec]

Works properly now when min > max.

[NathanSweet]

I think I would prefer if min > max then we either do nothing or the input is invalid and we throw an exception. If you are clamping a value to a range, it doesn't make sense to pass a min > max.

[MobiDevelop]

I'd agree that passing a min which is greater than max is invalid input.

[NathanSweet]

Shall we check it and throw or leave it silent?

[guillaume-alvarez]

I'd vote to check it and throw: earlier you fail, earlier you fix.

[NathanSweet]

My worry is someone relies on the behavior. If you pass a min > max then the function correctly returns false. It would actually be annoying to need to check for min > max if you wanted false back in that case. I guess my vote is that it isn't necessarily an error if min > max so we can leave the method as is.

[xoppa]

Fwiw, I'd say that clamp is a shortcut for min(max(x, minVal), maxVal) (which is how opengl defines the method). I don't think that it should throw an exception, nor swap arguments (which is what this PR does).

[NathanSweet]

Agreed.