Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShaderTester, it wraps Khronos shader compiler #3446

Closed
wants to merge 1 commit into from

Conversation

intrigus
Copy link
Contributor

This PR adds a thin wrapper around the the official Khronos reference shader compiler, it can process
whole directories and shaders as Strings.

There are some open questions:
It should be also possible to directly use the compiler through JNI, this would remove the limitation, that e.g. fragment shader MUST have .frag as extension.
But I don't know anything about JNI and jnigen.

Mac support is not available because, there are no binaries available for Mac.

The biggest problem is https://github.com/intrigus/libgdx/blob/9a4e6620b0d96116803b521f994d6d447e084104/extensions/gdx-tools/src/com/badlogic/gdx/tools/shadertester/ShaderTester.java#L41-L105 this is stolen from SharedLibraryLoader.getExtractedFile(). The method I copied is private so I'd have to invoke SharedLibraryLoader.getExtractedFile() through Reflection, which would remove duplicated code, but I don't like relying on Reflection.

Add the official Khronos reference shader compiler, it can be process
whole directories and shaders as Strings
@xoppa
Copy link
Member

xoppa commented Oct 7, 2015

Thanks! I don't think there's a need for this though. Shader editors typically provide the same (and more) information in a more convenient way.

@badlogic
Copy link
Member

badlogic commented Jan 5, 2016

Yeah, thanks Intrigus, but what Xoppa said :)

@badlogic badlogic closed this Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants