Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upMake APK expansion initialization faster. Make exists() faster for files #3471
Conversation
| FileHandle zipHandle = new AndroidZipFileHandle(path); | ||
| if (zipHandle.exists()) | ||
| handle = zipHandle; | ||
| handle = new AndroidZipFileHandle(path); |
This comment has been minimized.
This comment has been minimized.
MobiDevelop
Oct 8, 2015
Member
Shouldn't this only fallback to the expansion file if the type is Internal?
This comment has been minimized.
This comment has been minimized.
sarkanyi
Oct 8, 2015
Author
Contributor
I think you're right. While I'm still at this, let's fix this too.
Fall back to APK expansion only in case of internal files Simplify getAssetFileDescriptor()
MobiDevelop
added a commit
that referenced
this pull request
Oct 8, 2015
Make APK expansion initialization faster. Make exists() faster for files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sarkanyi commentedOct 8, 2015
It seems that if there are lots of entries in the obb file, exists() is rather slow because it has to search a large HashMap. This should make it much faster.