Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix AndroidZipFileHandle.length() throwing NullPointerException #3473
Conversation
…se the file doesn't exists
MobiDevelop
added a commit
that referenced
this pull request
Oct 9, 2015
Fix AndroidZipFileHandle.length() throwing NullPointerException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sarkanyi commentedOct 9, 2015
If the file doesn't exists AndroidZipFileHandle.length() throws a NullPointerException which is wrong. Looks like the FreetypeFontGenerator uses FileHandle.length() to check if a font is an actual file or has to be generated so that is the most obvious way to catch this.