Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch pressure support on ios and android #5270

Merged
merged 10 commits into from Jul 16, 2018

Conversation

@piotr-j
Copy link
Contributor

commented Jun 15, 2018

Implemented touch pressure on android and ios, modified multitouch test to use it.
Could use some feedback!
#5241

@piotr-j

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

Any idea why does the pr check fails?

@Tom-Ski

This comment has been minimized.

Copy link
Member

commented Jun 28, 2018

The interface methods are not implemented in all implementing classes. GwtInput is the one its failing on.

@piotr-j

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2018

Aw snap, dunno how did i miss that!

PiotrJ added some commits Jun 28, 2018

@lukz

This comment has been minimized.

Copy link

commented Jun 28, 2018

Awesome! Really need this one!

@@ -110,6 +110,14 @@ public boolean isTouched(int pointer) {
return false;
}

@Override public float getPressure () {

This comment has been minimized.

Copy link
@Tom-Ski

Tom-Ski Jun 28, 2018

Member

Can you format these overrides?

PiotrJ
@piotr-j

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2018

Any other dumb things that i missed?

@balepc

This comment has been minimized.

Copy link

commented Jul 6, 2018

This is very expected!!! Could you, please, merge it?

@Tom-Ski Tom-Ski merged commit e8d8b48 into libgdx:master Jul 16, 2018

1 check passed

LibGDX PR Check
Details

@SimonIT SimonIT referenced this pull request Jul 28, 2018

Closed

Touch pressure #5241

@piotr-j piotr-j deleted the piotr-j:pressure branch Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.