Workaround for macOS OpenGL performance issues. #5893

PokeMMO · 2020-01-25T05:55:05Z

Some macOS users experience a large performance degradation rendering 3D with default ModelBatch settings. This workaround seems to greatly alleviate this issue. ~~This issue may be specific to AMD graphics drivers, and if so we may want to limit this workaround to AMD GL renderer strings.~~ Update: Third link says it also afflicts nvidia

If there are any better ways to handle this, I'm all ears.

UIUtils.isMac used because it already handles gwt emulation here.

See:

fabiitch · 2020-01-25T08:37:44Z

gdx/src/com/badlogic/gdx/graphics/g3d/utils/DefaultTextureBinder.java

@@ -66,8 +70,13 @@ public DefaultTextureBinder (final int method, final int offset, final int count
 	}

 	public DefaultTextureBinder (final int method, final int offset, int count, final int reuseWeight) {
-		final int max = Math.min(getMaxTextureUnits(), MAX_GLES_UNITS);
-		if (count < 0) count = max - offset;
+		int max = Math.min(getMaxTextureUnits(), MAX_GLES_UNITS);


Should let final no?

Yeah, but it's probably not worth the effort to change back.

fabiitch · 2020-01-25T08:37:44Z

gdx/src/com/badlogic/gdx/graphics/g3d/utils/DefaultTextureBinder.java

-		if (count < 0) count = max - offset;
+		int max = Math.min(getMaxTextureUnits(), MAX_GLES_UNITS);
+		if (count < 0) {
+			if (enableMacOSWorkaround && UIUtils.isMac && Gdx.app.getType() == ApplicationType.Desktop)


There is no other method to know if the application run on macOs? It include a class from scene2d

Not as far as I could see. At least none compatible with gwt.

@PokeMMO
UIUutils#isMac does not check if it's mac os and is not compatible with GWT, why?
I think it does, also in GWT.

libgdx/backends/gdx-backends-gwt/src/com/badlogic/gdx/backends/gwt/emu/com/badlogic/gdx/scenes/scene2d/utils/UIUtils.java

Lines 9 to 12 in 8f09a42

public class UIUtils {

static public boolean isMac = Navigator.getPlatform().contains("Mac");

static public boolean isWindows = Navigator.getPlatform().contains("Win");

static public boolean isLinux = Navigator.getPlatform().contains("Linux");

So if the check isMac works, i'd not recommend to add DefaultTextureBinder#enableMacOSWorkaround

btw: #5910 extends UIUtils by UIUtils#isAndroid and UIUtils#isIos, the pr is currently in progress to test, may if you request changes to this constants, i could look for a solution that ensures that it's mac, if it's not doing right now.

UIUutils#isMac works fine, we also check if it's a desktop app to avoid interfering with GWT.

DefaultTextureBinder#enableMacOSWorkaround exists to allow users to disable this workaround in their own apps more easily.

DefaultTextureBinder#enableMacOSWorkaround exists to allow users to disable this workaround in their own apps more easily.

OK, so my 2nd question: If we have a DefaultTextureBinder#enableMacOSWorkaround flag that is only used for some few or only(?) an architecture of mac, why it does not work for all? And does the developer have to identify when to enable this? And how to handle this while deploying, shouldn't do this libgdx automatically, depending on the cpu / system architecture you are using / the app is deployed?

and my third question is:
https://stackoverflow.com/a/42320505 is the answer of your first link, and in the issue on stack, this guy used more than MAX_GLES_UNITS as count(?), so isn't the solution to reduce the count to the correct value instead of to 1?

or did i get something wrong right now?
They are talking about
glBindAttribLocation, glGetAttribLocation, glActiveTexture(GL_TEXTURE0) and glActiveTexture(GL_TEXTURE0 + activeTexture);

Tom-Ski · 2020-01-25T20:37:14Z

This would just disable any mutli-texturing, no? Also the first and last link (the second being undetermined) seem to be talking about two different things. They might be related, but that would be need to be confirmed.

PokeMMO · 2020-01-25T22:41:25Z

This would just disable any mutli-texturing, no?

Effectively yeah.

Also the first and last link (the second being undetermined) seem to be talking about two different things. They might be related, but that would be need to be confirmed.

Looks like it yeah, I was linked to it after I made the PR and it looked like the same issue, but seems it's only similar. The underlying cause might be the same, but you're right we should verify this.

mgsx-dev · 2020-01-26T11:37:35Z

not sure it disable multi-texturing, i think it forces to use texture unit 1 (not zero), see ModelBatch default texture binder offset.

I agree, it needs more tests to confirm what's the issue exactly. I'd try several things: ROUND_ROBIN method, force to texture unit 0, other units, force count to 2, more. Also, take a look at GLProfiler stats : how many shader switches you have, what behavior with less switches. I don't have Mac hardware so i can't help.

If issue is confirmed, i would add a new binding strategy (method) "DISABLED" instead of forcing count/offset. Also add some documentation to warn users that parameters could not be used. It's a breaking change if user code rely on texture slots.

Tom-Ski · 2020-01-26T13:13:36Z

Well then it might work for 2 textures, but for any more it won't.

Were you experiencing this issue yourself @PokeMMO ?

PokeMMO · 2020-01-27T02:16:25Z

Were you experiencing this issue yourself @PokeMMO ?

Not personally, but another member of my team has recreated it. (Along with a slow, but steady stream of player complaints)

Setting it to round-robin, offset to 0, count to 2 still has the issue. The only time we've gotten decent results seems to be with count 1.

It seems to me the issue is more in the changing of the texture index instead of what it actually is. So offset 1 vs offset 0 has a minimal difference.

PokeMMO · 2020-02-01T18:40:01Z

I've deployed this workaround and have confirmation that this resolves the issue from several users.

mgsx-dev · 2020-03-10T17:27:21Z

This PR can't be merged as is because it disable multi texturing. In order to prevent texture unit changes, a clean solution would be :

to track already set units in BaseShader
call texture binder #bind with a "preferred" unit (API change required in texture binder)
and have a new DefaultTextureBinder method "no recycling" which always bind to the preferred unit.

However, since it seams related to some weird macos driver, i'm not sure it worth to make that change since it could cause more texture switches with good mac drivers.
As per @PokeMMO :

Intel GPUs are probably not affected
some Nvidia are (unconfirmed), some Nvidia aren't
some AMD are (confirmed)

So, we don't have enough information to choose at runtime between Minimize texture switches VS minimize shader unit changes.

PokeMMO · 2020-08-27T12:38:48Z

servo/pathfinder#337 seems to be resolving the same/a similar issue on another project. Their solution seems like it might be a better one.

PokeMMO force-pushed the upstream/macos-bind-perf-fix branch 2 times, most recently from e68702f to 52d58ae Compare January 25, 2020 07:05

Workaround for macOS OpenGL performance issues.

3d9670d

PokeMMO force-pushed the upstream/macos-bind-perf-fix branch from 52d58ae to 3d9670d Compare January 25, 2020 07:16

fabiitch reviewed Jan 25, 2020

View changes

crykn mentioned this pull request Mar 21, 2020

Updated default shaders for OpenGL 3.2 core profile #5960

Open

waywardmonkeys mentioned this pull request May 1, 2020

macOS Radeon performance woes servo/pathfinder#300

Closed

mgsx-dev added the GL label Sep 1, 2020

MrStahlfelge mentioned this pull request Sep 7, 2020

SkinComposer slows down the system on Mac OS raeleus/skin-composer#76

Closed

PokeMMO mentioned this pull request Nov 5, 2021

Very bad perfomance when using LWJGL3 on Mac OS X #6690

Closed

6 tasks

Workaround for macOS OpenGL performance issues. #5893

Workaround for macOS OpenGL performance issues. #5893

PokeMMO commented Jan 25, 2020 •

edited

fabiitch Jan 25, 2020

PokeMMO Jan 25, 2020

fabiitch Jan 25, 2020

PokeMMO Jan 25, 2020

mquickmann Feb 13, 2020 •

edited

PokeMMO Feb 13, 2020

mquickmann Feb 13, 2020 •

edited

Tom-Ski commented Jan 25, 2020

PokeMMO commented Jan 25, 2020

mgsx-dev commented Jan 26, 2020

Tom-Ski commented Jan 26, 2020

PokeMMO commented Jan 27, 2020 •

edited

PokeMMO commented Feb 1, 2020

mgsx-dev commented Mar 10, 2020

PokeMMO commented Aug 27, 2020

	public class UIUtils {
	static public boolean isMac = Navigator.getPlatform().contains("Mac");
	static public boolean isWindows = Navigator.getPlatform().contains("Win");
	static public boolean isLinux = Navigator.getPlatform().contains("Linux");

Workaround for macOS OpenGL performance issues. #5893

Are you sure you want to change the base?

Workaround for macOS OpenGL performance issues. #5893

Conversation

PokeMMO commented Jan 25, 2020 • edited

fabiitch Jan 25, 2020

Choose a reason for hiding this comment

PokeMMO Jan 25, 2020

Choose a reason for hiding this comment

fabiitch Jan 25, 2020

Choose a reason for hiding this comment

PokeMMO Jan 25, 2020

Choose a reason for hiding this comment

mquickmann Feb 13, 2020 • edited

Choose a reason for hiding this comment

PokeMMO Feb 13, 2020

Choose a reason for hiding this comment

mquickmann Feb 13, 2020 • edited

Choose a reason for hiding this comment

Tom-Ski commented Jan 25, 2020

PokeMMO commented Jan 25, 2020

mgsx-dev commented Jan 26, 2020

Tom-Ski commented Jan 26, 2020

PokeMMO commented Jan 27, 2020 • edited

PokeMMO commented Feb 1, 2020

mgsx-dev commented Mar 10, 2020

PokeMMO commented Aug 27, 2020

PokeMMO commented Jan 25, 2020 •

edited

mquickmann Feb 13, 2020 •

edited

mquickmann Feb 13, 2020 •

edited

PokeMMO commented Jan 27, 2020 •

edited