Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonotoneChainBuilder::findChainEnd: Assertion `start < npts' failed. #539

Closed
strk opened this issue Jan 12, 2022 · 2 comments
Closed

MonotoneChainBuilder::findChainEnd: Assertion `start < npts' failed. #539

strk opened this issue Jan 12, 2022 · 2 comments
Assignees
Milestone

Comments

@strk
Copy link
Member

strk commented Jan 12, 2022

Continuation of bug originally reported in https://trac.osgeo.org/geos/ticket/1003 -- still occurring in 3.9.0 according to https://gitlab.com/nibioopensource/pgtopo_update_sql/-/issues/193

The MonotoneChainBuilder::findChainEnd method was removed in 3.10 as part of a refactoring in commit c655bb7 (PR #414)

@strk strk self-assigned this Jan 12, 2022
@strk
Copy link
Member Author

strk commented Jan 12, 2022

The assert would fail when MonotoneChainBuilder::getChains gets called with a CoordinateSequence containing NO points (empty). An easy fix would be to just have ::getChain return nothing in that case, but it's important to get a testcase going. Should be something about noding as that's where MonotoneChainBuilder::getChain is used from

strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
See libgeos#539

Also enable previously disabled Geometry::difference test
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
See libgeos#539

Includes unit test and NEWS item

Also moves Geometry::difference test where it belongs
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
See libgeos#539

Includes unit test.
Also moves Geometry::difference test where it belongs
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
See libgeos#539

Also enable previously disabled Geometry::difference test and moved
it to where it belongs
strk added a commit to strk/libgeos that referenced this issue Jan 12, 2022
See libgeos#539

Includes unit test and NEWS item

Also moves Geometry::difference test where it belongs, and enable
it (it was previously disabled).
strk added a commit that referenced this issue Jan 12, 2022
Closes GH-539

Includes unit test and NEWS item

Also moves Geometry::difference test where it belongs, and enable
it (it was previously disabled).
@pramsey pramsey added this to the 3.9.3 milestone Jan 12, 2022
@strk
Copy link
Member Author

strk commented Jan 17, 2022

The Closes GH-539 commit log message did NOT result in closing this issue. I now forgot what's the actual syntax to get GH ticket closed. Please GH fans help :) -- I'm closing this manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants