Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEOSGeom_setPrecision flattens multi-geometries #662

Closed
pramsey opened this issue Aug 16, 2022 · 3 comments
Closed

GEOSGeom_setPrecision flattens multi-geometries #662

pramsey opened this issue Aug 16, 2022 · 3 comments

Comments

@pramsey
Copy link
Member

pramsey commented Aug 16, 2022

So no-op precision reductions end up having a spurious type change as well:

geosop -a "MULTILINESTRING((0 0,10 10))" -f wkt reducePrecision 1

LINESTRING (0 0, 10 10)
@pramsey
Copy link
Member Author

pramsey commented Aug 16, 2022

@dr-jts thoughts?

@pramsey
Copy link
Member Author

pramsey commented Aug 16, 2022

Reported in https://trac.osgeo.org/postgis/ticket/5208

pramsey added a commit that referenced this issue Mar 9, 2023
@pramsey
Add test for GH-662
b9fb56b
pramsey added a commit to pramsey/geos that referenced this issue Mar 9, 2023
@pramsey
Preserve collection-level of the input geometry on the output reduced…
05f46dc 
… geometry. References libgeosGH-662.
@pramsey pramsey mentioned this issue Mar 9, 2023
Closed
@dr-jts
Copy link
Contributor

dr-jts commented Mar 9, 2023

It seems reasonable to preserve the collection type of the input.

pramsey added a commit that referenced this issue Mar 10, 2023
@pramsey
Preserve collection-level of the input geometry on the output reduced…
cd49218 
… geometry.

A single-element MultiPolygon will no longer be output as a Polygon.
It is still possible that a Polygon will be reduced to a MultiPolygon,
if the reduction causes the shape to split into parts.
References GH-662.
Also relevant to https://trac.osgeo.org/postgis/ticket/5208
@pramsey pramsey closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pramsey @dr-jts