Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delaunay robustness by using longer floating point variable #117

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

Komzpa
Copy link
Contributor

@Komzpa Komzpa commented Sep 1, 2018

@dbaston
Copy link
Member

dbaston commented Sep 1, 2018

Long double is 64 bits in MSVC; I think you need to ifdef out the test.

@Komzpa
Copy link
Contributor Author

Komzpa commented Sep 5, 2018

@dbaston is there a chance to get it into 3.7.0 and backpatch to 3.6 before release of 3.7? :)

@dbaston
Copy link
Member

dbaston commented Sep 5, 2018

I think so. You said on the JTS ticket that you had reduced the failure case to a 5-point input; can you use that here?

@dbaston
Copy link
Member

dbaston commented Sep 27, 2018

@Komzpa ^^^

@Komzpa
Copy link
Contributor Author

Komzpa commented Oct 26, 2018

@dbaston using smaller case now, passes locally

@dbaston
Copy link
Member

dbaston commented Oct 26, 2018

@Komzpa Great! Can you please squash the commits and force-push?

@Komzpa
Copy link
Contributor Author

Komzpa commented Oct 26, 2018

done. isn't there squash-and-merge button on github PR merge though, why is it manual?

@dbaston
Copy link
Member

dbaston commented Oct 26, 2018

This is just a mirror of the GEOS repository.

@strk strk merged commit 67d6eaf into libgeos:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants