Use JTS doubledouble implementation instead of ttmath #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaston
reviewed
Apr 16, 2020
| static DD pow(const DD &d, int exp); | ||
| static DD trunc(const DD &d); | ||
|
|
||
| bool isNaN() const; |
There was a problem hiding this comment.
Many of these methods seem like good candidates for inlining (either by defining them where they're declared, or by using a .inl file like much of the older work)
There was a problem hiding this comment.
Mostly they don't get called except in the tests. Most of the work happens in the arithmetic operators and selfAdd/selfMultiply.
There was a problem hiding this comment.
Seems like just about all the methods should be inlineable, no? Would be interesting to see the performance diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ttmath library is quite large and full of fancy stuff like ASM and so on, and all we seem to need is doubledouble. Also ttmath has some issues on big-endian systems. Also, this implementation seems to be 5-10% faster than ttmath, and I haven't exactly fine tuned it. I think with some added unit tests from JTS we should consider dropping ttmath entirely, and maybe even back-porting this into 3.8, since there is no regression change at all (!!). (Maybe, at least so far testing only on my machine.)