Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake Windows install: keep geos-config.cmake #347

Closed
wants to merge 1 commit into from

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 16, 2020

For a correct Windows install, geos-config.cmake needs to be installed. This file is not related to the non-Windows geos-config utility.

This is a partial rollback of daf24a4 (sorry, I'm to blame!)

This issue found while developing #346, which when ready, will test to ensure that a CMake install works properly with GEOS on various platforms.

xref https://trac.osgeo.org/geos/ticket/1068

@pramsey
Copy link
Member

pramsey commented Nov 16, 2020

Merge?

@mwtoews
Copy link
Contributor Author

mwtoews commented Nov 17, 2020

Merge?

Yup, tested and ready to merge. This PR was tested in #346 (as d04c669) which fixed the issue. Compare AppVeyor's before vs. after.

Note there appear to be several CI issues with the Windows builds, which are unrelated. I hope someone is investigating these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants