Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Envelope::fromXY #356

Closed
wants to merge 1 commit into from
Closed

Conversation

dbaston
Copy link
Member

@dbaston dbaston commented Nov 29, 2020

@dr-jts
Copy link
Contributor

dr-jts commented Nov 29, 2020

Ok yes, this is one way to add a different parameter order. But you have to know this method exists and that you need to use it - which seems to have the same cognitive cost as simply using the current parameter order in the constructor! I guess it does help to highlight the unconventional order of the constructor params though.

@dbaston
Copy link
Member Author

dbaston commented Nov 29, 2020

Yeah, not sure changing the parameter order is worth it. I do think having a constructor that assumes sorted inputs (xmin, xmax) vs (x1, x2) is worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants