Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate complex UnaryUnion test with OverlayNG #358

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 30, 2020

Closes #1046

@pramsey
Copy link
Member

pramsey commented Nov 30, 2020

Thanks!

@strk strk merged commit ed684bb into libgeos:master Nov 30, 2020
@dr-jts
Copy link
Contributor

dr-jts commented Nov 30, 2020

This test was actually already present: https://github.com/libgeos/geos/blob/master/tests/xmltester/tests/robust/overlay/TestOverlay-shapely-829.xml

Would be nice to avoid duplication?

@pramsey
Copy link
Member

pramsey commented Nov 30, 2020

Is it? The coordinates look quite different.

@dr-jts
Copy link
Contributor

dr-jts commented Nov 30, 2020

@mwtoews
Copy link
Contributor Author

mwtoews commented Nov 30, 2020

@dr-jts was correct: it is in the test suite, under a different guise:

tests/xmltester/tests/robust/overlay/TestOverlay-geos-1046-union-lines.xml

We could probably take one of these tests out, as it is duplication. (Update I just noticed the comment above. 🤦 )

@dr-jts
Copy link
Contributor

dr-jts commented Nov 30, 2020

Yes, I suggest removing the file added in this PR.

I think it's nicer to start pruning the random assortment of tests in issues if they exist elsewhere. There's probably more dups to robust/overlay tests - should really clean them up.

@pramsey
Copy link
Member

pramsey commented Nov 30, 2020

Contra that I kind of like the issues files because they map back to ticket numbers. Can see if an old ticket has a test easily. And vice versa, can research "what was the problem this file was about".

@pramsey
Copy link
Member

pramsey commented Nov 30, 2020

Removed dupe file at 401aee7

@dr-jts
Copy link
Contributor

dr-jts commented Nov 30, 2020

Contra that I kind of like the issues files because they map back to ticket numbers. Can see if an old ticket has a test easily. And vice versa, can research "what was the problem this file was about".

That's a good point.

It would be nice if the issue filenames indicated what operation or issue they are testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants