-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate complex UnaryUnion test with OverlayNG #358
Conversation
|
Thanks! |
|
This test was actually already present: https://github.com/libgeos/geos/blob/master/tests/xmltester/tests/robust/overlay/TestOverlay-shapely-829.xml Would be nice to avoid duplication? |
|
Is it? The coordinates look quite different. |
|
@dr-jts was correct: it is in the test suite, under a different guise: We could probably take one of these tests out, as it is duplication. (Update I just noticed the comment above. 🤦 ) |
|
Yes, I suggest removing the file added in this PR. I think it's nicer to start pruning the random assortment of tests in |
|
Contra that I kind of like the issues files because they map back to ticket numbers. Can see if an old ticket has a test easily. And vice versa, can research "what was the problem this file was about". |
|
Removed dupe file at 401aee7 |
That's a good point. It would be nice if the issue filenames indicated what operation or issue they are testing. |
Closes #1046