Improve points co-linearity test in LineIntersector::hasIntersection. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add simple test based on area of triangle created by three points of the given segment and test point. The point intersects the segment, if area of the triangle is zero or close to zero: insignificant relatively to length of the segment. Two interesting observations: 1) The fix allows to pass the "point on segment" test discussed in http://trac.osgeo.org/geos/ticket/591 and PR: #40 2) All GEOS tests pass apart from (testA, test<13>): tests/unit/algorithm/RobustLineIntersectorTest.cpp:247 which is opposite to the "point on segment" test: segment located as close and parallel as possible to X axis, so it seems on X axis (so 0,0 intersects), but JTS/GEOS are expected to detect it's not on X axis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple test based on area of triangle created by three points of the given segment and test point.
The point intersects the segment, if area of the triangle is zero or close to zero: insignificant relatively to length of the segment.
Two interesting observations:
test<13>): tests/unit/algorithm/RobustLineIntersectorTest.cpp:247 which is opposite to the "point on segment" test:Segment located as close and parallel as possible to X axis, so it seems on X axis (so 0,0 intersects), but JTS/GEOS are expected to detect it's not on X axis.
I haven't tested this modification with JTS, but I might, so I could ask @dr-jts for comments too.