Install geosop using option BUILD_GEOSOP #445
Conversation
|
A second commit here adds an option to not build/install geosop, which might be wanted by folks that only need the library. E.g.: will disable the build/install of geosop to /path/to/bin. The default for this option is ON. Also note that I've verified that |
| @@ -9,4 +9,8 @@ | |||
| # See the COPYING file for more information. | |||
| ################################################################################ | |||
|
|
|||
| add_subdirectory(geosop) | |||
| option(BUILD_GEOSOP "Build geosop command-line interface" ON) | |||
There was a problem hiding this comment.
How about calling this GEOS_BUILD_GEOSOP, so that GEOS options are grouped together?
(And we should really change a couple of the others, like DISABLE_OVERLAYNG ==> GEOS_DISABLE_OVERLAYNG)
There was a problem hiding this comment.
I guess there is also an existing pattern for BUILD_.... So could continue with that.
There was a problem hiding this comment.
yeah, I know what you mean and did briefly consider the two conventions.
There was a problem hiding this comment.
If it helps, PROJ's CMake options use a BUILD_NAME convention for each tool, which is what swayed my decision here. The main reason why GEOS_ is prefixed to many CMake variables is to avoid clashes with other variables when creating large CMake projects. No other tool is named geosop, so no clash.
mwtoews
changed the title
|
I've merged the previous commits and made a few subtle changes, including to show a message for this option, and to remove unnecessary "RUNTIME" from the It seems there are a few unrelated CI failures. |
|
Thanks! Merged. |
I was expecting to find this new tool in
bin, but this PR should fix that.