TST: Failing test case for GEOSDistance floating point overflows #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, fixed in main, hopefully along with all other examples of this quirk. |
|
Also back ported into 3.9 at c5437e9 |
|
Thanks @pramsey ! Confirmed the fix is working for this specific case in pygeos. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case demonstrating that floating point overflow exceptions are raised by
GEOSDistancewhen calculating the distance between boundable geometries but not points with the same distance.This was detected in this pygeos issue. Over there, the floating point status is checked by numpy and bubbles up as a warning in Python.