-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OverlayNG: Interpolate M values #802
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
reviewed
Jan 18, 2023
|
Also |
a7cbdaa
to
a0a2656
Compare
Yes, seems reasonable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR adds support for interpolation of M values in OverlayNG. M values from the input are preserved and M values at constructed points are populated via linear interpolation if possible. Unlike the Z dimension, the
ElevationModelis not used to populate the M value of output coordinates that do not intersect segments with M values.This does not cover all cases - for example, if snap-rounding is required, I expect that M values will be lost. I will work on adding test cases so that these usages can be covered.
By not assuming the use of the
Coordinatetype, these changes also move further in the direction of using XY inputs without carrying around a Z value.