Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing blanks, add check step to keep code free of them #82

Closed
wants to merge 1 commit into from

Conversation

strk
Copy link
Member

@strk strk commented Apr 7, 2017

@mloskot see how you like this

Does not change external code (tinyxml)
@strk strk changed the title Does this still work ? Remove trailing blanks, add check step to keep code free of them Apr 7, 2017
@strk
Copy link
Member Author

strk commented Apr 7, 2017

See also how Dronie likes it: https://git.osgeo.org/gogs/geos/geos/pulls/2

@strk strk closed this Apr 7, 2017
@strk strk deleted the no-trailing-blanks branch April 7, 2017 20:21
@mloskot
Copy link
Contributor

mloskot commented Apr 7, 2017

@strk

@mloskot see how you like this

If you ask me, it doesn't solve any of my problems.
It doesn't unify tabs/spaces, indentation, brackets placement, and <here long list>.
Besides, check step is covered by only one of two official build configurations.

You know my opinion, .editorconfig is no improvement to the current situation.
It is as just a small helper that has very little to do with formatting style of a complex source code.

However, I don't want to interfere, do what you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants